From 9a75bcc8106e0ab2110a1e49d0610dd2ac490f32 Mon Sep 17 00:00:00 2001 From: Yasien Mac Mini Date: Fri, 28 Nov 2025 13:38:14 +0200 Subject: [PATCH] QOL: MIH Access Controls Package performance improvements pt2 --- .../builder/build_business_access_list.dart | 2 - .../package_tools/mih_access_requests.dart | 89 +++++++++---------- 2 files changed, 44 insertions(+), 47 deletions(-) diff --git a/Frontend/lib/mih_packages/access_review/builder/build_business_access_list.dart b/Frontend/lib/mih_packages/access_review/builder/build_business_access_list.dart index f5508113..31af7cfe 100644 --- a/Frontend/lib/mih_packages/access_review/builder/build_business_access_list.dart +++ b/Frontend/lib/mih_packages/access_review/builder/build_business_access_list.dart @@ -483,8 +483,6 @@ class _BuildPatientsListState extends State { MihAccessControllsProvider accessProvider, Widget? child) { return ListView.separated( - shrinkWrap: true, - physics: const NeverScrollableScrollPhysics(), separatorBuilder: (BuildContext context, index) { return Divider( color: MihColors.getSecondaryColor( diff --git a/Frontend/lib/mih_packages/access_review/package_tools/mih_access_requests.dart b/Frontend/lib/mih_packages/access_review/package_tools/mih_access_requests.dart index a40ad884..241fce12 100644 --- a/Frontend/lib/mih_packages/access_review/package_tools/mih_access_requests.dart +++ b/Frontend/lib/mih_packages/access_review/package_tools/mih_access_requests.dart @@ -7,7 +7,6 @@ import 'package:mzansi_innovation_hub/mih_config/mih_env.dart'; import 'package:mzansi_innovation_hub/mih_packages/access_review/builder/build_business_access_list.dart'; import 'package:mzansi_innovation_hub/mih_services/mih_access_controls_services.dart'; import 'package:mzansi_innovation_hub/mih_services/mih_validation_services.dart'; -import 'package:mzansi_innovation_hub/mih_package_components/mih_single_child_scroll.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_dropdwn_field.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_package_tool_body.dart'; import 'package:flutter/material.dart'; @@ -83,50 +82,50 @@ class _MihAccessRequestState extends State { child: Mihloadingcircle(), ); } - return MihSingleChildScroll( - child: Column( - children: [ - Row( - mainAxisAlignment: MainAxisAlignment.center, - crossAxisAlignment: CrossAxisAlignment.end, - mainAxisSize: MainAxisSize.max, - children: [ - Flexible( - child: MihDropdownField( - controller: filterController, - hintText: "Access Type", - dropdownOptions: const [ - "All", - "Approved", - "Pending", - "Declined", - "Cancelled", - ], - requiredText: true, - editable: true, - enableSearch: true, - validator: (value) { - return MihValidationServices().isEmpty(value); - }, - ), - ), - IconButton( - iconSize: 35, - onPressed: () { - setState(() { - forceRefresh = true; - }); - KenLogger.warning("Refreshing Access List"); - refreshList(); + return Column( + children: [ + Row( + mainAxisAlignment: MainAxisAlignment.center, + crossAxisAlignment: CrossAxisAlignment.end, + mainAxisSize: MainAxisSize.max, + children: [ + Flexible( + child: MihDropdownField( + controller: filterController, + hintText: "Access Type", + dropdownOptions: const [ + "All", + "Approved", + "Pending", + "Declined", + "Cancelled", + ], + requiredText: true, + editable: true, + enableSearch: true, + validator: (value) { + return MihValidationServices().isEmpty(value); }, - icon: const Icon( - Icons.refresh, - ), ), - ], - ), - const SizedBox(height: 10), - BuildBusinessAccessList( + ), + IconButton( + iconSize: 35, + onPressed: () { + setState(() { + forceRefresh = true; + }); + KenLogger.warning("Refreshing Access List"); + refreshList(); + }, + icon: const Icon( + Icons.refresh, + ), + ), + ], + ), + const SizedBox(height: 10), + Expanded( + child: BuildBusinessAccessList( filterText: filterController.text, onSuccessUpate: () { setState(() { @@ -135,8 +134,8 @@ class _MihAccessRequestState extends State { refreshList(); }, ), - ], - ), + ), + ], ); }, );