From ad967254785c457d88221fba8a4304fa8a6cd886 Mon Sep 17 00:00:00 2001 From: Yasien Mac Mini Date: Fri, 28 Nov 2025 13:48:25 +0200 Subject: [PATCH] QOL: Mzansi Profile Package performance improvements pt2 --- .../builders/build_employee_list.dart | 2 - .../builders/build_user_list.dart | 2 - .../mih_business_user_search.dart | 61 +++++++++---------- .../package_tools/mih_my_business_team.dart | 9 +-- 4 files changed, 31 insertions(+), 43 deletions(-) diff --git a/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_employee_list.dart b/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_employee_list.dart index 6ea114da..b15b6d4f 100644 --- a/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_employee_list.dart +++ b/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_employee_list.dart @@ -35,8 +35,6 @@ class _BuildEmployeeListState extends State { builder: (BuildContext context, MzansiProfileProvider mzansiProfileProvider, Widget? child) { return ListView.separated( - shrinkWrap: true, - physics: const NeverScrollableScrollPhysics(), separatorBuilder: (BuildContext context, index) { return Divider( color: MihColors.getSecondaryColor( diff --git a/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_user_list.dart b/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_user_list.dart index 5e840533..73e5ecea 100644 --- a/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_user_list.dart +++ b/Frontend/lib/mih_packages/mzansi_profile/business_profile/builders/build_user_list.dart @@ -42,8 +42,6 @@ class _BuildUserListState extends State { builder: (BuildContext context, MzansiProfileProvider profileProvider, Widget? child) { return ListView.separated( - shrinkWrap: true, - physics: const NeverScrollableScrollPhysics(), separatorBuilder: (BuildContext context, index) { return Divider( color: MihColors.getSecondaryColor( diff --git a/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_business_user_search.dart b/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_business_user_search.dart index bab9181f..024fe46b 100644 --- a/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_business_user_search.dart +++ b/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_business_user_search.dart @@ -1,6 +1,5 @@ import 'package:mzansi_innovation_hub/main.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_icons.dart'; -import 'package:mzansi_innovation_hub/mih_package_components/mih_single_child_scroll.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_package_tool_body.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_search_bar.dart'; import 'package:mzansi_innovation_hub/mih_objects/app_user.dart'; @@ -44,7 +43,7 @@ class _MihBusinessUserSearchState extends State { Widget displayUserList(MzansiProfileProvider profileProvider) { if (profileProvider.userSearchResults.isNotEmpty) { - return BuildUserList(); + return Expanded(child: BuildUserList()); } if (hasSearchedBefore && userSearch.isNotEmpty) { return Column( @@ -168,37 +167,35 @@ class _MihBusinessUserSearchState extends State { return Consumer( builder: (BuildContext context, MzansiProfileProvider profileProvider, Widget? child) { - return MihSingleChildScroll( - child: Column( - mainAxisSize: MainAxisSize.max, - children: [ - Padding( - padding: EdgeInsets.symmetric(horizontal: width / 20), - child: MihSearchBar( - controller: searchController, - hintText: "Search Users", - prefixIcon: Icons.search, - fillColor: MihColors.getSecondaryColor( - MzansiInnovationHub.of(context)!.theme.mode == "Dark"), - hintColor: MihColors.getPrimaryColor( - MzansiInnovationHub.of(context)!.theme.mode == "Dark"), - onPrefixIconTap: () { - submitUserForm(profileProvider); - }, - onClearIconTap: () { - setState(() { - searchController.clear(); - userSearch = ""; - }); - profileProvider.setUserearchResults(userSearchResults: []); - }, - searchFocusNode: _searchFocusNode, - ), + return Column( + mainAxisSize: MainAxisSize.max, + children: [ + Padding( + padding: EdgeInsets.symmetric(horizontal: width / 20), + child: MihSearchBar( + controller: searchController, + hintText: "Search Users", + prefixIcon: Icons.search, + fillColor: MihColors.getSecondaryColor( + MzansiInnovationHub.of(context)!.theme.mode == "Dark"), + hintColor: MihColors.getPrimaryColor( + MzansiInnovationHub.of(context)!.theme.mode == "Dark"), + onPrefixIconTap: () { + submitUserForm(profileProvider); + }, + onClearIconTap: () { + setState(() { + searchController.clear(); + userSearch = ""; + }); + profileProvider.setUserearchResults(userSearchResults: []); + }, + searchFocusNode: _searchFocusNode, ), - const SizedBox(height: 10), - displayUserList(profileProvider), - ], - ), + ), + const SizedBox(height: 10), + displayUserList(profileProvider), + ], ); }, ); diff --git a/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_my_business_team.dart b/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_my_business_team.dart index 90b7a440..3801f4c2 100644 --- a/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_my_business_team.dart +++ b/Frontend/lib/mih_packages/mzansi_profile/business_profile/package_tools/mih_my_business_team.dart @@ -1,5 +1,4 @@ import 'package:mzansi_innovation_hub/main.dart'; -import 'package:mzansi_innovation_hub/mih_package_components/mih_single_child_scroll.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_package_tool_body.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_loading_circle.dart'; import 'package:mzansi_innovation_hub/mih_providers/mzansi_profile_provider.dart'; @@ -31,7 +30,7 @@ class _MihMyBusinessTeamState extends State { Widget displayEmployeeList(List employeeList) { if (employeeList.isNotEmpty) { - return BuildEmployeeList(); + return Expanded(child: BuildEmployeeList()); } return Center( child: Text( @@ -71,11 +70,7 @@ class _MihMyBusinessTeamState extends State { child: Mihloadingcircle(), ); } - return MihSingleChildScroll( - child: Column(mainAxisSize: MainAxisSize.max, children: [ - displayEmployeeList(mzansiProfileProvider.employeeList!), - ]), - ); + return displayEmployeeList(mzansiProfileProvider.employeeList!); }, ); }