From cea8ccab5a42ac7d0d78f7d334cd9f4ac0a1bf23 Mon Sep 17 00:00:00 2001 From: Yasien Mac Mini Date: Fri, 28 Nov 2025 13:02:34 +0200 Subject: [PATCH] QOL: Mzansi Wallet Package performance improvements pt2 --- .../builder/build_loyalty_card_list.dart | 2 - .../package_tools/mih_card_favourites.dart | 21 ++------ .../package_tools/mih_cards.dart | 49 +++++++++---------- 3 files changed, 28 insertions(+), 44 deletions(-) diff --git a/Frontend/lib/mih_packages/mzansi_wallet/builder/build_loyalty_card_list.dart b/Frontend/lib/mih_packages/mzansi_wallet/builder/build_loyalty_card_list.dart index c9d279fe..9a7e84bf 100644 --- a/Frontend/lib/mih_packages/mzansi_wallet/builder/build_loyalty_card_list.dart +++ b/Frontend/lib/mih_packages/mzansi_wallet/builder/build_loyalty_card_list.dart @@ -659,8 +659,6 @@ class _BuildLoyaltyCardListState extends State { MzansiWalletProvider walletProvider, Widget? child) { return GridView.builder( - physics: const NeverScrollableScrollPhysics(), - shrinkWrap: true, padding: EdgeInsets.only( left: getHorizontalPaddingSize(size), right: getHorizontalPaddingSize(size), diff --git a/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_card_favourites.dart b/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_card_favourites.dart index 726c445a..9e5a0f62 100644 --- a/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_card_favourites.dart +++ b/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_card_favourites.dart @@ -1,6 +1,5 @@ import 'package:flutter/material.dart'; import 'package:mzansi_innovation_hub/mih_providers/mzansi_wallet_provider.dart'; -import 'package:mzansi_innovation_hub/mih_package_components/mih_single_child_scroll.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_package_tool_body.dart'; import 'package:mzansi_innovation_hub/mih_objects/loyalty_card.dart'; import 'package:mzansi_innovation_hub/mih_packages/mzansi_wallet/builder/build_loyalty_card_list.dart'; @@ -40,21 +39,11 @@ class _MihCardFavouritesState extends State { } Widget getBody() { - return Stack( - children: [ - MihSingleChildScroll( - child: Column( - children: [ - BuildLoyaltyCardList( - cardList: listOfCards, - navIndex: 0, - favouritesMode: true, - searchText: TextEditingController(), - ), - ], - ), - ), - ], + return BuildLoyaltyCardList( + cardList: listOfCards, + navIndex: 0, + favouritesMode: true, + searchText: TextEditingController(), ); } } diff --git a/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_cards.dart b/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_cards.dart index 98f5b828..3fa5eae6 100644 --- a/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_cards.dart +++ b/Frontend/lib/mih_packages/mzansi_wallet/package_tools/mih_cards.dart @@ -3,7 +3,6 @@ import 'package:mzansi_innovation_hub/main.dart'; import 'package:mzansi_innovation_hub/mih_providers/mzansi_wallet_provider.dart'; import 'package:mzansi_innovation_hub/mih_config/mih_colors.dart'; import 'package:mzansi_innovation_hub/mih_packages/mzansi_wallet/components/mih_add_card_window.dart'; -import 'package:mzansi_innovation_hub/mih_package_components/mih_single_child_scroll.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_package_tool_body.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_floating_menu.dart'; import 'package:mzansi_innovation_hub/mih_package_components/mih_search_bar.dart'; @@ -111,30 +110,28 @@ class _MihCardsState extends State { } return Stack( children: [ - MihSingleChildScroll( - child: Column( - children: [ - Padding( - padding: EdgeInsets.symmetric(horizontal: width / 20), - child: MihSearchBar( - controller: cardSearchController, - hintText: "Search Cards", - // prefixIcon: Icons.search, - prefixIcon: Icons.search, - fillColor: MihColors.getSecondaryColor( - MzansiInnovationHub.of(context)!.theme.mode == - "Dark"), - hintColor: MihColors.getPrimaryColor( - MzansiInnovationHub.of(context)!.theme.mode == - "Dark"), - onPrefixIconTap: () { - // print("Search Icon Pressed: ${cardSearchController.text}"); - }, - searchFocusNode: searchFocusNode, - ), + Column( + children: [ + Padding( + padding: EdgeInsets.symmetric(horizontal: width / 20), + child: MihSearchBar( + controller: cardSearchController, + hintText: "Search Cards", + // prefixIcon: Icons.search, + prefixIcon: Icons.search, + fillColor: MihColors.getSecondaryColor( + MzansiInnovationHub.of(context)!.theme.mode == "Dark"), + hintColor: MihColors.getPrimaryColor( + MzansiInnovationHub.of(context)!.theme.mode == "Dark"), + onPrefixIconTap: () { + // print("Search Icon Pressed: ${cardSearchController.text}"); + }, + searchFocusNode: searchFocusNode, ), - const SizedBox(height: 10), - ValueListenableBuilder>( + ), + const SizedBox(height: 10), + Expanded( + child: ValueListenableBuilder>( valueListenable: searchShopName, builder: (context, filteredCards, child) { return BuildLoyaltyCardList( @@ -145,8 +142,8 @@ class _MihCardsState extends State { ); }, ), - ], - ), + ), + ], ), Positioned( right: 10,